Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove avm use prompt, and insist on user installing a version if it's not yet installed #1565

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

SvenDowideit
Copy link
Contributor

@SvenDowideit SvenDowideit commented Mar 7, 2022

Closes #1562

replaces #1558

avm/src/lib.rs Outdated Show resolved Hide resolved
@paul-schaaf
Copy link
Contributor

LGTM. pls add a line to the breaking section of the changelog

@SvenDowideit
Copy link
Contributor Author

SvenDowideit commented Mar 13, 2022

root@4e25ea78ccf3:/# avm use 0.22.1
Error: Could not parse version file: unexpected end of input while parsing major version number
root@4e25ea78ccf3:/# avm use latest
Error: Could not parse version file: unexpected end of input while parsing major version number

I guess there's something else i need to learn about in the code :)

(oh, this happens when there's no version installed, and the code currently tries and fails to parse nothing)

@SvenDowideit
Copy link
Contributor Author

ok, added a fix for the initial condition

avm/src/lib.rs Outdated Show resolved Hide resolved
@paul-schaaf paul-schaaf merged commit e567e14 into coral-xyz:master Mar 17, 2022
@paul-schaaf
Copy link
Contributor

thank you!

@SvenDowideit SvenDowideit deleted the avm-install-before-use branch March 18, 2022 00:00
@SvenDowideit
Copy link
Contributor Author

oops, sorry for the dependency :)

SvenDowideit added a commit to SvenDowideit/anchor-book that referenced this pull request Mar 18, 2022
paul-schaaf pushed a commit to coral-xyz/anchor-book that referenced this pull request Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

avm: make avm use return error if anchor version is not installed (instead of prompting)
3 participants