-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove avm use prompt, and insist on user installing a version if it's not yet installed #1565
Merged
paul-schaaf
merged 2 commits into
coral-xyz:master
from
SvenDowideit:avm-install-before-use
Mar 17, 2022
Merged
remove avm use prompt, and insist on user installing a version if it's not yet installed #1565
paul-schaaf
merged 2 commits into
coral-xyz:master
from
SvenDowideit:avm-install-before-use
Mar 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomlinton
reviewed
Mar 7, 2022
SvenDowideit
force-pushed
the
avm-install-before-use
branch
from
March 7, 2022 02:39
2d37597
to
47dbeed
Compare
LGTM. pls add a line to the breaking section of the changelog |
SvenDowideit
force-pushed
the
avm-install-before-use
branch
from
March 13, 2022 04:35
47dbeed
to
ed2b7ad
Compare
I guess there's something else i need to learn about in the code :) (oh, this happens when there's no version installed, and the code currently tries and fails to parse nothing) |
ok, added a fix for the initial condition |
SvenDowideit
added a commit
to SvenDowideit/anchor-book
that referenced
this pull request
Mar 13, 2022
paul-schaaf
reviewed
Mar 13, 2022
… not yet installed
SvenDowideit
force-pushed
the
avm-install-before-use
branch
from
March 17, 2022 01:58
23fa392
to
9bfa480
Compare
paul-schaaf
approved these changes
Mar 17, 2022
thank you! |
oops, sorry for the dependency :) |
SvenDowideit
added a commit
to SvenDowideit/anchor-book
that referenced
this pull request
Mar 18, 2022
paul-schaaf
pushed a commit
to coral-xyz/anchor-book
that referenced
this pull request
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1562
replaces #1558