Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lang: new internal writer to use bpf mem syscalls #1589

Merged
merged 5 commits into from
Mar 12, 2022
Merged

lang: new internal writer to use bpf mem syscalls #1589

merged 5 commits into from
Mar 12, 2022

Conversation

callensm
Copy link
Member

@callensm callensm commented Mar 8, 2022

resolves #1585

@callensm callensm marked this pull request as ready for review March 8, 2022 23:13
@callensm callensm changed the title lang: new internal writer to use bpf syscalls lang: new internal writer to use bpf mem syscalls Mar 8, 2022
@paul-schaaf
Copy link
Contributor

CreateOfficer from the cfo test goes from Program consumption: 83366 units remaining to Program consumption: 91197 units remaining.

Huge difference

@paul-schaaf
Copy link
Contributor

might have to keep using Cursor for non bpf targets. we're not sure if it's necessary.
https://discord.com/channels/428295358100013066/517163444747894795/950946676670078986

@callensm
Copy link
Member Author

callensm commented Mar 9, 2022 •
edited

might have to keep using Cursor for non bpf targets. we're not sure if it's necessary. https://discord.com/channels/428295358100013066/517163444747894795/950946676670078986

ok cool, just let me know when you find out. I can add some target arch checks in there for the writer instantiations.

@callensm
Copy link
Member Author

callensm commented Mar 9, 2022

@paul-schaaf do the target arch configs in the source code not deal with this?

@paul-schaaf
Copy link
Contributor

oh thats right they do!

paul-schaaf
paul-schaaf reviewed Mar 9, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@armaniferrante armaniferrante merged commit ad8aec2 into coral-xyz:master Mar 12, 2022
@callensm callensm deleted the lang/bpf_writer branch March 14, 2022 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-schaaf paul-schaaf paul-schaaf left review comments

@armaniferrante armaniferrante Awaiting requested review from armaniferrante

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lang: create writer that uses the solana bpf mem syscalls and replace std::io::Cursor with the new writer
3 participants
@callensm @paul-schaaf @armaniferrante