Lower fees as voted plz #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for this. this requires no changes for anyone, maybe the communication to let people know about this. and, we can have the new fees immediately for everyone. |
jhlx
reviewed
Dec 7, 2021
| } | ||
|
|
||
| #[inline(always)] | ||
| const fn rebate_bps(bps: u64) -> U64F64 { |
There was a problem hiding this comment.
Maybe we keep this as rebate_tenth_of_bps for use below.
jhlx
reviewed
Dec 7, 2021
dex/src/fees.rs
Outdated
| }; | ||
| rate.mul_u64(pc_qty).floor() | ||
| pub fn maker_rebate(self, _pc_qty: u64) -> u64 { | ||
| 0 |
There was a problem hiding this comment.
Maybe we use rebate_tenth_of_bps(0).mul_u64(pc_qty).floor(). Not sure why we used to add a 2^-64 rebate to every tier before, but can keep it just for consistency.
|
Looks great, thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special fee tier for stable needs more thinking so this should come later.
https://dao.projectserum.com/#/proposal/7GxS9nEc4ZiTjgSpTxg7JnsJXfyayoJocSdzAj5PmWR8?programId=AVoAYTs36yB5izAaBkxRG67wL1AMwG3vo41hKtUSb8is