You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If there is better way for you like bumping solana-program and/or spl, please let us know.
Details
Well, there are various crates involved.
Firstly, solana-program crates use serde. And serde v1.0.122 now depends on syn>= v1.0.60specifically and it broke build of borsh-rs< v0.8.0: near/borsh-rs#2 (this pr should be in borsh-rs v0.8.0)
Then, serum-dex uses both solana-program and borsh-rs, which would be unable to build with conflicting versions.
(A bit odd thing is that it seems spl succeeded to build with syn v1.0.60 and it seems pinning syn isn't working in your repository for some reason...)
CC: @armaniferrante (mentioning based on relevant commit's author info, nice to meet you!), @mvines (my dependable rust dependency-hell solving expert.)
The text was updated successfully, but these errors were encountered:
Thanks for the issue @ryoqun. I'm happy to update our borsh fork and no longer pin syn (we pinned it as a temporary workaround for near/borsh-rs#2). I'll probably get to it sometime next week, likely. If it's more urgent, please let me know and I'm happy to to get to it sooner.
Hi! I'm an engineer from solana. :)
To make long story short, could you update your forked
borsh
crate to be rebased ontoborsh-rs
v0.8.1?We noticed updating
serde
to v1.0.122 at the solana monorepo would breakserum-dex
build: https://buildkite.com/solana-labs/solana/builds/38795#a018ae71-7d4c-4dc2-a9a9-fab840bcd3ef/1360-1834. Don't worry. We won't do that soon. This is just maintenance update at our side. :)If there is better way for you like bumping
solana-program
and/orspl
, please let us know.Details
Well, there are various crates involved.
Firstly,
solana-program
crates useserde
. Andserde
v1.0.122 now depends onsyn
>= v1.0.60
specifically and it broke build ofborsh-rs
< v0.8.0
: near/borsh-rs#2 (this pr should be inborsh-rs v0.8.0
)Then,
serum-dex
uses bothsolana-program
andborsh-rs
, which would be unable to build with conflicting versions.serum-dex/pool/Cargo.toml
Line 20 in d470586
serum-dex/Cargo.lock
Lines 238 to 275 in d470586
These changes seems to be introduced by this pr: #51
Also, it seems that you're also pinning
syn
at forked branch:https://github.com/project-serum/borsh/blob/90fcdf51f4c0333002a00a2db7367cc672882dc5/borsh-rs/borsh-derive-internal/Cargo.toml#L17
by this commit https://github.com/project-serum/borsh/pull/1/commits/884c56711c732d172f5d65374feff1fb796d4841
It may become unnecessary?
Also, updated
borsh-rs
isn't pinningsyn
it seems: https://github.com/near/borsh-rs/blob/3dddc6d7af2e66bf4f5947c0187a9d1f7dae6888/borsh-schema-derive-internal/Cargo.toml#L16So, I'm thinking you can just update
borsh-rs
to v0.8.1, considering it's not pinningsyn
version: https://crates.io/crates/borsh-derive-internal/0.8.1(A bit odd thing is that it seems
spl
succeeded to build withsyn v1.0.60
and it seems pinningsyn
isn't working in your repository for some reason...)CC: @armaniferrante (mentioning based on relevant commit's author info, nice to meet you!), @mvines (my dependable rust dependency-hell solving expert.)
The text was updated successfully, but these errors were encountered: