Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LRAS Indicator Index is sometimes incorrect #40

Closed
cnkeats opened this issue Dec 8, 2020 · 2 comments
Closed

LRAS Indicator Index is sometimes incorrect #40

cnkeats opened this issue Dec 8, 2020 · 2 comments
Projects
Slippi

Comments

@cnkeats
Copy link
Contributor

cnkeats commented Dec 8, 2020

The LRAS Initiator set in the Game End event often indicates that Player 1 left when it was actually Player 2. Across over 2000 .slp files where the index is NOT -1, less than 5% of the quits are indicated as being from Player 2, but it would be expected for it to actually be about 50%.

Attached are 5 example files where Player 2 leaves but the LRAS Initiator Index is 0 instead of 1.

badLRAS.zip
@cnkeats
Copy link
Contributor Author

cnkeats commented Dec 9, 2020

This appears to only happen on Unranked and doesn't affect direct.

@cnkeats
Copy link
Contributor Author

cnkeats commented Dec 10, 2020

This was fixed in this commit.

@cnkeats cnkeats closed this as completed Dec 10, 2020
@NikhilNarayana NikhilNarayana added this to Done in Slippi Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Slippi
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cnkeats