Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F-Droid #59

Closed
Rudloff opened this issue May 27, 2018 · 20 comments
Closed

F-Droid #59

Rudloff opened this issue May 27, 2018 · 20 comments
Assignees

Comments

@Rudloff
Copy link

Rudloff commented May 27, 2018

Hello,

Would you be interested in publishing this app on F-Droid?

@Swati4star
Copy link
Member

@Rudloff Sure! You can add a merge request for this project on FdroidData.

@Rudloff
Copy link
Author

Rudloff commented May 30, 2018

Great!

Would it be possible to tag releases?
This makes packaging a lot easier.

@Swati4star
Copy link
Member

Hi @Rudloff ! Sure. Just specify the tag format you want me to create. Also, make the app auto update on Fdroid.

@Rudloff
Copy link
Author

Rudloff commented Jun 1, 2018

If we want to enable auto update, the easiest way is to have tags that match the version name of the app (e.g. 2.0 for the current version).

@Swati4star
Copy link
Member

https://github.com/project-travel-mate/Travel-Mate/releases/tag/2.0

Let me know if you want me to do any other change.

@Rudloff
Copy link
Author

Rudloff commented Jun 1, 2018

It looks good to me, I will try to work on it next week.

@Rudloff
Copy link
Author

Rudloff commented Jun 3, 2018

Sorry, I just noticed you are using some Play Services libraries:

implementation 'com.google.android.gms:play-services-maps:15.0.1'

Unfortunately, these are not open-source so we can't include it in F-Droid (unless we could build a variant of your app wihtout these libraries but that's probably a lot of work).

@Swati4star
Copy link
Member

We need maps in our application. After all, this is a travel app!

@Rudloff
Copy link
Author

Rudloff commented Jun 3, 2018

If you are interested, there are some open-source alternatives to Google Maps like osmdroid.

I'm sorry, I didn't notice this dependency when I first had a look at your code. But I'm afraid this means we can't publish it on F-Droid.

@Rudloff Rudloff closed this as completed Jun 3, 2018
@Swati4star
Copy link
Member

Hi @Rudloff ! We have removed the usage of google maps, and replaced it with osmdroid.
Can you check if it can be published on f-droid now?

@Rudloff
Copy link
Author

Rudloff commented Oct 19, 2018

That is great!
It should be OK now. I will start working on packaging the app.

@Rudloff Rudloff reopened this Oct 19, 2018
@Rudloff
Copy link
Author

Rudloff commented Oct 19, 2018

@Swati4star I created a build recipe for the app: https://gitlab.com/fdroid/fdroiddata/merge_requests/3803
I just had to remove the http://repo.commonsware.com.s3.amazonaws.com repository (not sure how it is used).

Do you think it would be possible to add Git tags for 3.9.2 and future releases? It makes packaging updates a lot easier.

@Swati4star
Copy link
Member

Hi @Rudloff
Sure, I'll add git tag for current & future releases as well.
https://github.com/project-travel-mate/Travel-Mate/releases/tag/3.9.2

@Swati4star
Copy link
Member

I think, adding https to the url will solve the issue.

@Swati4star
Copy link
Member

The gitlab build should pass after this commit, 25ed727

I have created a new release with the above commit included also.

@Rudloff
Copy link
Author

Rudloff commented Oct 21, 2018

Everything works correctly now, thanks!

@Swati4star
Copy link
Member

Do share the fdroid link, when it is merged on gitlab.

@guest4711
Copy link

It's on f-droid now: Travel Mate (A complete travel guide) - https://f-droid.org/app/io.github.project_travel_mate

@LuccoJ
Copy link

LuccoJ commented Nov 3, 2018

I've opened an issue concerning the app at https://gitlab.com/fdroid/fdroiddata/issues/1429 because I feel it's not presented in an ideal way in its F-Droid description. I would appreciate if the app's developers could weigh in on the stated concerns, as they would necessarily be the best-informed parties about the services the application makes use of and their status wrt tracking and freedom.

Please keep in mind that while my issue may sound like criticism of the application, the goal is just to have applications consistently described in F-Droid and let users know what to expect.

@Swati4star
Copy link
Member

I'll update the readme soon to incorporate your comments 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants