Update for Flutter 3 #116
Merged
Update for Flutter 3 #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nullsafety는 6월 안까지는 도입하도록 해볼게요 ㅠㅠ |
This reverts commit 05097d3.
violet-dev
reviewed
May 15, 2022
| @@ -41,6 +43,8 @@ | |||
| </array> | |||
| <key>UIViewControllerBasedStatusBarAppearance</key> | |||
| <false/> | |||
| <key>CADisableMinimumFrameDurationOnPhone</key> | |||
There was a problem hiding this comment.
이미 프로모션 성능에 문제가 없기 때문에 도입 고려 필요
Preload 가능하도록 변경 작업 Revert하였습니다. 또한 PreloadPageView 및 VPhotoViewGallery 업데이트 진행도 함께 하였습니다. PreloadPageView 업데이트 같은경우 Flutter 3.0.0 PageView 기반으로 하였으며 VPhotoViewGallery 는 최신 패키지를 참고하였습니다. |
violet-dev
approved these changes
May 19, 2022
| @@ -8,6 +9,7 @@ import Flutter | |||
| didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? | |||
| ) -> Bool { | |||
| GeneratedPluginRegistrant.register(with: self) | |||
| FlutterDownloaderPlugin.setPluginRegistrantCallback(registerPlugins) | |||
There was a problem hiding this comment.
iOS에선 Flutter Downloader가 필요없습니다
Flutter Downloader는 앱 업데이트를 위해 apk를 다운로드할 때만 사용합니다.
| @@ -370,7 +372,7 @@ class _SearchPageState extends State<SearchPage> | |||
| leading: SizedBox( | |||
| width: 25, | |||
| height: 25, | |||
| child: FlareArtboard(artboard, | |||
| child: FlareActor.asset(asset, | |||
There was a problem hiding this comment.
Search Bar Page에서 Back할 때 애니메이션이 실행되지 않음
|
너무 많은 예상치 못한 버그가 발생해서 revert합니다 |
패키지 업데이트로 인해 버그가 많은거 같아 빌드 세팅 업데이트, 패키지 업데이트로 분리하여 PR 다시 만들도록하겠습니다! |
violet-dev
added a commit
that referenced
this pull request
May 29, 2022
* viewer: remove top padding appbar when ios * viewer: ui fit for ios * article-info: fix download button * card-panel: enable container color on ios * eh-login: update deprecated code * viewer: fit ios pad * viewer: fit for ios * viewer: add pad to settings for ios: * settings: fix navigation error on ios, BookmarkVersionSelectPage * viewer: expand exit button horizontal padding for ios * version: update version (1.22.0) * version: update pubspec * article-info: refresh script every read, download button tapped * artist-info: set back color on article more info for ios * card-seg: fix background not shown * card-panel: fix back color for ios * viewer: replace jumpTo to scrollTo for bypassing ScrollablePositionedList redraw item when jumpTo * viewer: reload when load failed * package: downgrade scrollable_positioned_list for fix viewer InterativeViewer zoom not working * viewer: apply lazy slider * viewer: add thumb * viewer: increase thumb height * viewer: thumb is only supported in filesys * viewer: break thumb scroll animation * viewer: increase thumb height * viewer: fit thumb using raw-image width * viewer: scroll selected thumb to middle * database: remove db_path preference * settings: add thumbsize option * viewer: reduce thumb border radius, pad * download: auto recovery for ios * viewer: fix text color on record panel * viewer: upscale thumb image * viewer: expand slider width * viewer: fix viewer thumbnails page mismatch * viewer: jump to page always when slider end * hiyobi: fix image getter when webp hash is null * article: light vibration on bookmarking * settings: add enableThumbSlider option * viewer: add comments to local variables * viewer: set is image loaded alway true when filesys mode * filter-page: code refactoring * viewer: fix bug thumb slider on in provider type * settings: add usingPushReplacementOnArticleRead option * type-menu: fix text wrap error * download: implements global retry, recovery * download: reposition feature, align button * download: refresh global key when align changed * download: fix global key cannot refresh error * download: fix download widget key is not accessable on other list-widget * type-menu: fix text wrap error * download: remove singlechildscrollview on download item menu * download: implements copy all urls * download: implements add list of urls * viewer: animate thumb slider on image list move * viewer: fix page timer not working in horizontal mode * package: update photo_view for fix looking up a deactivated widget's ancestor is unsafe error * ios: fix textfield long press gray screen error * ref: flutter/flutter#70767 (comment) * download: show ReadProgressOverlayWidget, PagesOverlayWidget * download: gray scale when latest read page is last page * download: fix get download widget key function * trivial: change developer user app id prefix * lock: implements lock screen * platform: enable fingerpring, faceid option * lock: fix missing password message * lock: apply black theme * lock: set number pad height to 300px * settings: useLockScreen to default false * version: update version (1.23.0) * settings: add show page number indicator option to viewer * trivial: translate some korean * viewer: fix check latest read condition error * settings: add showRecordJumpMessage to viewer * lock: add haptic feedback, sound * download: fix filter * download: fix refresh function * download: fix filter query results mismatching bug * download: fix but that thumbnail not chaged when filtering * article-info: check already downloaded * settings: fix language korean to ko * viewer: fix _rightButtonEvent * version: update version (1.23.1) * settings: implements settings-wrapper class * viewer: extract thumb controller method * viewer: extract double point listener * viewer: extract custom double tap gesture detector * viewer: remove unused container * settings: add secure mode option (hide violet from app list) * ios: fix secure mode option * afterloading: screen lock when app inactive, use secure mode * viewer: _prevPage setState to ValueNotifier for optimize * viewer: fix thumb controller nullref, use valuenotifier for bookmark * viewer: disable thumb excluding on filesys mode * script: fix refresh, decrease update delay * package: update windows for flutter_js * script: remove overlapping refreshing code * afterloading: setState after navigation on app inactive * article-info: copy id when tap * secure-mode: enable secure mode when app startup * afterloading: show lock screen when resumed * version: update version (1.23.2) * script: fix image provider refresh critical type error * script: refresh on search message * package: add wakelock package * ios: support iPhone13 Pro, Pro Max 120hz promotion * ios: decrease minimum frame rate range * Revert "ios: decrease minimum frame rate range" This reverts commit 76912a9. * Revert "ios: support iPhone13 Pro, Pro Max 120hz promotion" This reverts commit 97f1954. * download-item: skip global recovery when item is downloaded from eh * settings: add downloadEhRawImage option * eh-provider: set ts_l default * settings: fix image route error * eh: add get small images url * eh: fix original image address getter * settings: add download item align option * download: reverse download align based on page count * test: update test code * download: add align type * download: fix align default not appiled * download: fix file thumbnail cache size * patchnote: update patchnote * bookmark: refactoring refresh method * downloader: fix 'group' download rule keyword is always null bug * flutter-3.0: update flutter dependency * flutter-3.0: update flutter dependency * flutter-3.0: update flutter dependency * Update gitignore * flutter-3.0: apply firebase * ios: enable firebase libraries * Revert "Update gitignore" This reverts commit f8f0722. * Update gitignore * gitignore 적용 * db/bookmark: fix bookmark group article query error * database: fix database query ignoring error * main/settings: transparent to status bar * version: update version (1.24.0) * version: update version (1.24.0) * Remove Duplicate import and Unused import * Update for Flutter 3 * Update pubspec.lock * Update AppFrameworkInfo * Update flutter_downloader and add downloader ios setting * Open File Package Android Setting * Url Launcher Package Ios and Android Setting * permission handler Package Ios Setting * Add webview flutter AndroidWebView * Revert "Open File Package Android Setting" This reverts commit 05097d3. * Update Android Gradle * Update flare_flutter * Change VPhotoViewGallery to PhotoViewGallery * Update cert_util * Change thread/semaphore.dart to semaphore Package * Update fluttertoast * fixed deprecatied * Update build.gradle * Revert "Change VPhotoViewGallery to PhotoViewGallery" This reverts commit f79a394. * Update VPhotoViewGallery and PreloadPageView * Update dependencies * Cleanup gradle * Update xcconfig * Fix MainActivaity * Update dependencies * Revert "Merge pull request #116 from ykh09242/patch-3" This reverts commit a026e9e, reversing changes made to eea1a46. * search: fix flare close animation not working * Migrate Flutter 3.0 Build Setting * 불필요 설정 제거 * Dev null safety (#120) * enable null safety * algorithm / cert * checker * component * database * downloader / locale / log / model/ network / other * cert / main / settings / thread / version / test * script / server * some pages * pages / commit before test * update packages / check build ok * fix runtime errors * Fix impossible conditional (#119) * Update README.md libviolet no longer used * database: add lock sync timeout * bookmark: add scrollbar to bookmark article list * bookmark: add bookmark scrollbars & bookmarkScorllbarPositionToLeft option * Add flutter_lints * database: remove debugprint * package: update package * lint: remove unused null ref * viewer: set memcachewidth to x1.5 when useLowPerf * Enable use_key_in_widget_constructors lint * Enable `sort_child_properties_last` lint * Remove duplicate * Enable `String` lint * viewer: add cache to horizontal * package: update packages * viewer: default page indicator number to 1 * assets: update related.json * project: add asset of 7z only for android * comments: fix null ref * flutter: fix null ref errors * database: remove lock * bookmark: remove black background * *critical* search: fix key is null * Revert "database: remove lock" This reverts commit d0ae95b. * Revert "Revert "database: remove lock"" This reverts commit 15aa4f7. * database: remove lock mechanism * ios: replace pod cdn * Revert "ios: replace pod cdn" This reverts commit 54c0929. * Enable `prefer_conditional_assignment` lint * database: wait open when proxy creation * Revert "Revert "ios: replace pod cdn"" This reverts commit eb477a6. * Revert "Revert "Revert "ios: replace pod cdn""" This reverts commit 0befdb0. * Enable `prefer_const_constructors_in_immutables` lint * Update article_list_item_widget.dart * Fix must_be_immutable * Change createState * search: list article item caching is not necessary * database: reopen database connection when closed * widgets: extract dot indicator * database: fix reopen database connection when closed (ref 510861f) * Revert "search: list article item caching is not necessary" This reverts commit 440614d. * search: ResultPanelWidget to StatlessWidget * search: fix key specification * Revert "search: fix key specification" This reverts commit cf20fa4. * Revert "search: ResultPanelWidget to StatlessWidget" This reverts commit dc5e0e4. * search: fix bug that null ref, no rendered item has not context * search/bookmark-article: fix caching bug * Enable `prefer_collection_literals` lint * rebase * Update group_article_list_page.dart * Enable `prefer_const_constructors` lint * rebase * Enable `prefer_const_literals_to_create_immutables` lint * Update dots_indicator.dart * assets: update related.json * assets: update related.json * assets: update related.json * database-download: fix indexing null ref error * main: refactoring main page * viewer: tiny refactoring Co-authored-by: Park Dong Uk <phk09242@gmail.com>
DPS0340
pushed a commit
to DPS0340/violet
that referenced
this pull request
Nov 15, 2022
Update for Flutter 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(패키지 업데이트 분량이 커 제외된 업데이트 패키지: fluttertoast, flare_dart, flare_flutter)로 업데이트 필요하지만 업데이트 시 오류가 발생하여 미수정으로 두었습니다.로 업데이트가 필요하지만 업데이트 시 오류가 발생하여 미수정으로 두었습니다.dart sdk 버전 업데이트도 필요하지만 nullsafety 작업이 되어있지않아 그대로두었습니다.
(추가) Gradle 버전이 올라가면서 useProguard가 기본적으로 활성화되도록 바뀌어 Gradle 업데이트 시 오류가 발생했던거였습니다. useProguard 제거 후 Gradle 버전 업데이트 진행하였습니다. stackoverflow link
APK 빌드까지는 오류없이 되는 것 확인하였습니다. 하지만 그 외 플랫폼 빌드 및 실행 테스트는 해보지못하여 필요없다 판단되신다면 PR 닫아주셔도됩니다 _ _