Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 compatibility #14

Closed
eptbertram opened this issue Oct 24, 2022 · 6 comments
Closed

PHP 8 compatibility #14

eptbertram opened this issue Oct 24, 2022 · 6 comments
Labels
enhancement New feature or request
Milestone

Comments

@eptbertram
Copy link

I tested sepaPP today with PHP 8.1.11 and could not activate this extension on my CiviCRM 5.53.0 with WordPress 6.0.3.
Can anybody confirm this? CiviSEPA itself seems to work fine: Project60/org.project60.sepa#645

@bjendres
Copy link
Member

Thanks @eptbertram, would you be able to provide a PR?

@bjendres bjendres added the enhancement New feature or request label Oct 24, 2022
@bjendres bjendres added this to the 1.1 milestone Oct 24, 2022
@eptbertram
Copy link
Author

Thanks @eptbertram, would you be able to provide a PR?

I'm sorry, I'm not able to help. Maybe in two weeks.

@bjendres
Copy link
Member

Sure, whenever you can find the time :) Thanks.

@tpokorra
Copy link

I think this has already been resolved in master in September 2021 by 29db6d5
But release 1.0 was before that, in March 2021.

I was able to install sepapp from master with PHP 8.1

bjendres added a commit that referenced this issue Jan 13, 2023
bjendres added a commit that referenced this issue Jan 13, 2023
@bjendres
Copy link
Member

bjendres commented Jan 13, 2023

@eptbertram, @sebbrandt87: Could you please confirm that 1.1-alpha1 (still) works for you (on PHP8)? If so, I'll release it as 1.1,0.

@eptbertram
Copy link
Author

@bjendres @sebbrandt87: Thank you!
I can confirm that https://github.com/Project60/org.project60.sepapp/releases/tag/1.1-alpha1 is working fine on PHP8.1 (CiviCRM 5.57.0). Go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants