util.py: make sure that the git commit ID is a string, not bytes #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owtaylor
added a commit
to owtaylor/osbs-box
that referenced
this pull request
Feb 15, 2018
Instead of building from source, use the Fedora updates-testing packages. Push a couple of fixes into the Dockerfile: containerbuildsystem/osbs-client#730 containerbuildsystem/atomic-reactor#920 containerbuildsystem/atomic-reactor#921
subprocess.check_output() by default returns bytes for python3. Using universal_newlines=True is a trick to get strings for both python2 and python3, since the encoding option is python3 only.
owtaylor
force-pushed
the
commit-id-string
branch
from
bcce322
to
fb609e6
Compare
rcerven
approved these changes
Feb 16, 2018
|
Updated draft release notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subprocess.check_output() by default returns bytes for python3. Using
universal_newlines=True is a trick to get strings for both python2
and python3, since the encoding option is python3 only.
I hit this in testing atomic-reactor running with Python-3.6 - not sure why it hasn't previously been encountered since the code hasn't apparently changed for quite a while. The symptom that is seen is that the code in add_labels_in_df that escapes the environment values blows up if an environment value is bytes instead of string since b"Foo".translate() wants a different argument than "foo".translate().