Skip to content
This repository has been archived by the owner on Oct 10, 2020. It is now read-only.

Unhelpful error message due to wide Exception catching #1144

Open
mscherer opened this issue Dec 8, 2017 · 2 comments
Open

Unhelpful error message due to wide Exception catching #1144

mscherer opened this issue Dec 8, 2017 · 2 comments
Assignees

Comments

@mscherer
Copy link

mscherer commented Dec 8, 2017

Today, I did setup a Fedora 26 atomic VM and while trying to follow openshift ansible documentation, I stumbled on a curious bug:

# atomic install --storage=ostree --name=openshift_ansible --system openshift/origin-ansible 
string indices must be integers

Turn out the traceback is being hidden by https://github.com/projectatomic/atomic/blob/master/atomic#L211

That's not a very good UI since this mean people can't report accurate information or error, and would assume the error is on their side rather than on the code side (because that's what happened to me, I did read the doc twice to figure what was wrong on the argument I gave, rather than a bug that I could correct and/or report), so I would propose to merge the Exception and AssertionError handling to show the traceback, just to be clear this is not a normal error.

@mscherer
Copy link
Author

mscherer commented Dec 8, 2017

In the mean time, I found --debug to show the traceback, but the point is still valid, we should not show unexpected errors as regular error. Something along the line "unexpected error, please run again with --debug" would at least help to understand the problem is not supposed to be "normal".

@rhatdan
Copy link
Member

rhatdan commented Dec 9, 2017

@baude PTAL

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants