remove flatpak_base_image #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlangsdorf
reviewed
Oct 22, 2018
| @@ -126,14 +124,10 @@ def set_params(self, | |||
| self.koji_parent_build.value = koji_parent_build | |||
| self.koji_upload_dir.value = koji_upload_dir | |||
| self.flatpak.value = flatpak | |||
| self.flatpak_base_image.value = flatpak_base_image | |||
There was a problem hiding this comment.
You'll need to change atomic_reactor/schemas/user_params.json in atomic-reactor
There was a problem hiding this comment.
ok will make that change
| @@ -189,7 +189,6 @@ def __init__(self): | |||
| self.koji_kerberos_principal = BuildParam("koji_kerberos_principal", allow_none=True) | |||
| self.koji_kerberos_keytab = BuildParam("koji_kerberos_keytab", allow_none=True) | |||
| self.flatpak = BuildParam("flatpak", default=False) | |||
| self.flatpak_base_image = BuildParam("flatpak_base_image", allow_none=True) | |||
There was a problem hiding this comment.
I don't think you want to change build_request v1 here - that changes the behavior of Arrangement 5- systems.
There was a problem hiding this comment.
I think we're fine with making changes that only affect flatpak builds, as they are not working prior to arrangement 6 in any case.
rcerven
force-pushed
the
flatpak_fix
branch
3 times, most recently
from
490998b
to
e57f2bd
Compare
Signed-off-by: Robert Cerven <rcerven@redhat.com>
twaugh
approved these changes
Nov 6, 2018
mlangsdorf
approved these changes
Nov 6, 2018
|
Release notes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robert Cerven rcerven@redhat.com