core/scripts: Support /var/lib/rpm-state #1319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was trying a `--ex-unified-core` compose of FAW, and things fell over on `urw-base35-fonts` which does a dance of setting a stamp file in `%post` and checking it in `%posttrans`. This whole pattern should be considered deprecated by file triggers. But let's support it for now. Note there's a lot of parameter passing as we need a single directory which is held across multiple script invocations.
jlebon
reviewed
Mar 28, 2018
src/libpriv/rpmostree-core.c
Outdated
| &n_post_scripts_run, cancellable, error)) | ||
| return FALSE; | ||
| } | ||
|
|
||
| /* file triggers */ | ||
| if (!run_all_transfiletriggers (self, ordering_ts, tmprootfs_dfd, | ||
| if (!run_all_transfiletriggers (self, ordering_ts, tmprootfs_dfd, |
There was a problem hiding this comment.
Minor: looks like a stray trailing space here.
src/libpriv/rpmostree-scripts.c
Outdated
| * | ||
| * See above for why we special case glibc. | ||
| */ | ||
| const gboolean is_glibc_locales = strcmp (pkg_script, "glibc-all-langpacks.posttrans") == 0; | ||
| bwrap = rpmostree_bwrap_new (rootfs_fd, | ||
| is_glibc_locales ? RPMOSTREE_BWRAP_MUTATE_FREELY : RPMOSTREE_BWRAP_MUTATE_ROFILES, | ||
| error, | ||
| /* Scripts can see a /var with compat links like alternatives */ |
| @@ -328,25 +330,43 @@ run_script_in_bwrap_container (int rootfs_fd, | |||
| else | |||
| created_var_tmp = TRUE; | |||
|
|
|||
| /* And similarly for /var/lib/rpm-state */ | |||
There was a problem hiding this comment.
How about making this hunk conditional on var_lib_rpm_statedir?
|
Fixup ⬆️ |
|
⚡ Test exempted: merge already tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying a
--ex-unified-corecompose of FAW, and things fell overon
urw-base35-fontswhich does a dance of setting a stamp file in%postand checking it in%posttrans.This whole pattern should be considered deprecated by file triggers. But let's
support it for now.
Note there's a lot of parameter passing as we need a single directory which is
held across multiple script invocations.