[merged] This variable starts out so unsubstituted. Until the end. #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A future commit is going to change our parsing of the "ref" member in treefiles, so ensure we only load it once early on in compose-tree. We already looked up the previous commit there, so just pass it down rather than reloading the ref.
This comes from the tradition of yum repo files. It's significantly
easier for rpm-ostree users building multiple architectures if some
core templating for the treefiles is built in.
Otherwise, everyone needs to learn about a new wrapper tool for
rpm-ostree, and said tool would need to re-do the same "basearch"
evaluation that is already occuring inside libhif.
This commit also paves the way for introducing `${releasever}`
substitution.
NOTE: This depends on pending changes to libhif git.
cgwalters
changed the title
|
This depends on rpm-software-management/libdnf#112 |
|
@cgwalters-bot retry |
|
bot, retest this please |
| @@ -32,6 +32,7 @@ | |||
| #include <libhif/hif-utils.h> | |||
| #include <libhif/hif-package.h> | |||
| #include <librepo/librepo.h> | |||
| #include <librepo/librepo.h> | |||
|
Can't we use |
|
Hmm, right, we don't really have a HifRepo to begin with here. |
|
I was trying to think of a way to leverage what libhif already does for this, but there's nothing that really jumps out. |
cgwalters-bot
pushed a commit
that referenced
this pull request
Apr 28, 2016
This comes from the tradition of yum repo files. It's significantly
easier for rpm-ostree users building multiple architectures if some
core templating for the treefiles is built in.
Otherwise, everyone needs to learn about a new wrapper tool for
rpm-ostree, and said tool would need to re-do the same "basearch"
evaluation that is already occuring inside libhif.
This commit also paves the way for introducing `${releasever}`
substitution.
NOTE: This depends on pending changes to libhif git.
Closes: #274
Approved by: jlebon
|
☀️ Test successful - status-atomicjenkins |
cgwalters-bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.