Skip to content
This repository has been archived by the owner on Jul 29, 2018. It is now read-only.

service-manager command kills running docker containers on first execution #12

Closed
navidshaikh opened this issue Feb 9, 2016 · 4 comments

Comments

@navidshaikh
Copy link
Collaborator

From @hferentschik on December 16, 2015 12:7

vagrant adbinfo kills all running Docker containers on first execution (for example the running OpenShift container as per https://github.com/redhat-developer-tooling/openshift-vagrant setup).

This is due to the fact that adbinfo re-generates TLS certificates for the Docker daemon when it is first called - https://github.com/projectatomic/vagrant-adbinfo/blob/master/lib/command.rb#L65. As part of this the Docker daemon gets restarted which kills all already running containers. In the context of redhat-developer-tooling/openshift-vagrant this means that after a first call to vagrant adbinfo, vagrant provision needs to be called again, in order to restart the OpenShift container.

The plugin should not do these VM modifications steps as part of the command execution, but it should rather register itself as a provisioner and do the required changes as part of the VM bootstrap.

Copied from original issue: projectatomic/vagrant-adbinfo#55

@navidshaikh
Copy link
Collaborator Author

From @hferentschik on December 16, 2015 12:7

Could someone please add the label foxus:devex.

@navidshaikh
Copy link
Collaborator Author

From @LalatenduMohanty on January 27, 2016 15:11

@navidshaikh @hferentschik Is it already resolved for CDK?

@navidshaikh
Copy link
Collaborator Author

From @hferentschik on January 28, 2016 11:31

Is it already resolved for CDK?

No, we are still not using OpenShift as a service, since there are still issues with the provided scripts. And even then, switching to OpenShift as a service might help in this particular case, the true solution is in the implementation of this plugin.

@navidshaikh
Copy link
Collaborator Author

From @hferentschik on January 28, 2016 11:52

I also quickly tested with the service scripts. In this case the OpenShift service indeed restarts after the Docker service restart, so OpenShift comes back up again. However, this is not a proper solution. Other containers which might have been started are still "lost" and one has a considerable downtime of the OpenShift service.

@navidshaikh navidshaikh changed the title adbinfo command kills running docker containers on first execution service-manager command kills running docker containers on first execution Feb 9, 2016
@navidshaikh navidshaikh added this to the "ADB 2.0 GA" milestone Feb 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant