Skip to content
This repository has been archived by the owner on Jul 29, 2018. It is now read-only.

Code refactoring #49

Closed
coolbrg opened this issue Feb 15, 2016 · 5 comments
Closed

Code refactoring #49

coolbrg opened this issue Feb 15, 2016 · 5 comments

Comments

@coolbrg
Copy link
Contributor

coolbrg commented Feb 15, 2016

After going through the plugin's code a while, I think we need to do major refactoring to meet the Ruby language's style and standards.

I will be working on it after some stable release version.

Action items:

  • Follow Ruby style guide throughout the plugin
  • Autoload files in vagrant-service-manager.rb
  • Change plugin names from Vagrant to VagrantPlugins
  • YML approach for doc strings(help text)
  • Service driven command structure #79 (Service driven command structure)
@hferentschik
Copy link
Contributor

+1 Absolutely required. It should also take into account that the plugin in the future does not only provide commands, but also uses other Vagrant plugin mechanisms (for example action hooks).

@coolbrg
Copy link
Contributor Author

coolbrg commented Feb 23, 2016

@hferentschik : Action hook has been used for configuring providers like docker, openshift, ... on vagrant up. PR here as #54 . It would be available in next release.

@bexelbie
Copy link
Contributor

Pending #54 I also think that the code in command.rb should be refactored so that the service specific bits live somewhere like lib/vagrant-service-manager/services/docker.rb. Other code like find_machine_ip can go in a common library.

If this isn't part of this PR (and I can go both ways) we need to do it ASAP.

@coolbrg
Copy link
Contributor Author

coolbrg commented Feb 26, 2016

@bexelbie lets keep it in this PR only. Will focus on refactoring after next release.

@bexelbie
Copy link
Contributor

Moved my last comment to #135

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants