Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an explicit field in bismark-active results for tool exit code. #8

Open
woodrow opened this issue Feb 28, 2012 · 2 comments
Open
Assignees
Milestone

Comments

@woodrow
Copy link
Member

woodrow commented Feb 28, 2012

  • make sure all of our tools actually give non-zero exit codes when they fail (and preferably different codes for different failure modes).
  • capture exit code in bismark-$TOOLNAME wrapper script and insert in output xml.
@woodrow woodrow closed this as completed Feb 28, 2012
@woodrow woodrow reopened this Feb 28, 2012
@woodrow
Copy link
Member Author

woodrow commented Feb 28, 2012

The measurement tables in the database already have an 'exitstatus' field, so that much is done at least.

   Column   |       Type       |    Modifiers    
------------+------------------+-----------------
...
 exitstatus | integer          | default (-9999)
...

@ghost ghost assigned ssundaresan Feb 28, 2012
@woodrow
Copy link
Member Author

woodrow commented Mar 26, 2012

Started with bismark-mstats.lua (bismark-devel/bismark@74d1792), which now accepts exit status as argument 5, and also properly errors out if it receives something other than numbers. Also added a 'count' attribute to the output XML.

USAGE: ./bismark-mstats.lua param toolname src_ip dst_ip exit_status [direction]
  where a series of real numbers, one per line, is provided to standard input
  to be summarized by ./bismark-mstats.lua

It looks like it's going to take quite a bit of of work to rearrange bismark-measure-active to work properly with this. Currently the bismark-$TOOL output is piped directly into bismark-mstats. We will need to store it in a temporary file so we can capture the exit code (i.e. $?) from bismark-$TOOL. Then we can cat the temporary file into bismark-mstats.lua, while also providing the exit code as an argument to bismark-mstats.lua.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants