Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Blacklight ViewComponents with a template should inherit from Blacklight::Component #2978

Closed
barmintor opened this issue Feb 2, 2023 · 0 comments · Fixed by #2979
Closed
Milestone

Comments

@barmintor
Copy link
Contributor

Some components were not updated to inherit from Blacklight::Component in 7.x; this confuses installer attempting to override the associated templates during migration.

app/components/blacklight/response/sort_component.rb:    class SortComponent < ViewComponent::Base
app/components/blacklight/response/view_type_component.rb:    class ViewTypeComponent < ViewComponent::Base
app/components/blacklight/response/view_type_button_component.rb:    class ViewTypeButtonComponent < ViewComponent::Base
app/components/blacklight/response/spellcheck_component.rb:    class SpellcheckComponent < ViewComponent::Base
app/components/blacklight/system/flash_message_component.rb:    class FlashMessageComponent < ViewComponent::Base
app/components/blacklight/system/dropdown_component.rb:    class DropdownComponent < ViewComponent::Base
app/components/blacklight/system/modal_component.rb:    class ModalComponent < ViewComponent::Base
@barmintor barmintor added this to the 8.0 milestone Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant