Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any chance of backporting view_component 3.x support to BL 7? #3052

Closed
jrochkind opened this issue Jul 5, 2023 · 3 comments
Closed

Any chance of backporting view_component 3.x support to BL 7? #3052

jrochkind opened this issue Jul 5, 2023 · 3 comments

Comments

@jrochkind
Copy link
Member

I am having a lot of trouble upgrading to Blacklight 8, I think it's going to be a while until I get there. Issues relevant to that filed at eg #3051, projectblacklight/blacklight_range_limit#236 and projectblacklight/blacklight_range_limit#237)

But that leaves me stuck on view_component 2.x, as for some reason BL 7 is incompat with 3.x. This has been fixed in BL8. I am worried about staying on view_component 2.x, as it will not be getting bugfixes anymore, may not be compatible with future versions of Rails, etc.

I wonder if it could be figured out what was changed to create view_component 3.x compat, and if that could be backported to Blacklight 7.x?

@jrochkind
Copy link
Member Author

jrochkind commented Jul 5, 2023

Possibly relevant PR's/commits, found just from log search, I don't have personal familiarity.

Don't know if these are exhaustive; don't know if they are easily back-ported

@jrochkind
Copy link
Member Author

Sadly the release-7.x branch isn't passing tests locally for me as is, even with view_component 2.x So that makes it a lot more of a challenge.

I am not sure if my failures are reproducible or not, but I get these failures:

rspec ./spec/components/blacklight/facet_item_pivot_component_spec.rb:34 # Blacklight::FacetItemPivotComponent links to the facet and shows the number of hits
rspec ./spec/helpers/blacklight/search_history_constraints_helper_behavior_spec.rb:50 # Blacklight::SearchHistoryConstraintsHelperBehavior render_search_to_s_* render_search_to_s_element does not escape with options set thus
rspec ./spec/helpers/blacklight/search_history_constraints_helper_behavior_spec.rb:34 # Blacklight::SearchHistoryConstraintsHelperBehavior render_search_to_s_* render_search_to_s_element escapes them that need escaping
rspec ./spec/helpers/blacklight/search_history_constraints_helper_behavior_spec.rb:25 # Blacklight::SearchHistoryConstraintsHelperBehavior render_search_to_s_* render_search_to_s_element renders basic element
rspec ./spec/controllers/catalog_controller_spec.rb:479 # CatalogController GET suggest returns suggestions
rspec ./spec/presenters/blacklight/show_presenter_spec.rb:69 # Blacklight::ShowPresenter link_rel_alternates with no arguments generates <link rel=alternate> tags

@jrochkind
Copy link
Member Author

Has already been backported to release-7.x branch in #3069

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant