Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unknown changed to [Missing] #190

Open
kosarko opened this issue Jun 3, 2022 · 2 comments
Open

Unknown changed to [Missing] #190

kosarko opened this issue Jun 3, 2022 · 2 comments

Comments

@kosarko
Copy link

kosarko commented Jun 3, 2022

I've noticed this change (the right is 0a1df5f and blacklight 7.25.2 the left v8.1.0 and blacklight 7.22.2)
image

Shouldn't the English locale value for key missing be used?

blacklight_range_limit/config/locales/blacklight_range_limit.en.yml

Line 8 in 31ff89a

missing: 'Unknown'

@kosarko
Copy link
Author

kosarko commented Jun 6, 2022

Oh, this is actually using blacklight.search.facets.missing. Is blacklight.range_limit.missing even used anywhere?

@barmintor
Copy link
Contributor

It looks like the blacklight.range_limit.missing translation is unused after a3fd1d4 (8.2.0+)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@barmintor @kosarko