Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use modern ViewComponent slot syntax as Blacklight #239

Closed
wants to merge 1 commit into from

Conversation

barmintor
Copy link
Contributor

- remove stub of removed method from presenter mock in spec
- fixes #238
@jrochkind
Copy link
Member

Thanks for this @barmintor . Before seeing you had done this, I went ahead with #240, more or less duplicating this.

This is necessary to use blacklight_range_limit with BL7 and view_component 3, which I would really like to do.

I think these failures are for unrelated reasons. I don't know how to fix them either, it seems tricky.

What if fixing the unrelated build errors is not a pre-requisite for fixing this PR?

These are small and targetted changes. I have tested the changes locally, blacklight_range_limit definitely still works (as long as you have view_component >= 2.54.0).

Thoughts on how to proceed?

@jrochkind
Copy link
Member

Somehow the .internal_test_app Gemfile is being generated with a corrupt gem version specification. This may be an engine_cart issue? I haven't been able to figure out where it's coming from or how to fix it.

@jrochkind
Copy link
Member

i can't get tests to run locally for other reasons, that are not this failure. When I try to run tests locally with bundle exec rake ci, I get the old:

Failure/Error: EngineCart.load_application!

FrozenError:
  can't modify frozen Array:  [...]
# /Users/jrochkind/.gem/ruby/3.2.2/gems/railties-7.0.8/lib/rails/engine.rb:574:in `unshift'

Which I have run into before, and don't know what to do with it.

@jrochkind
Copy link
Member

OK, I spent today figuring out why the build here was broken in this way, and filed this PR on blacklight:

projectblacklight/blacklight#3088

However, even after fixing that, the build STILL does not pass with Blacklight 8. It fails with other errors. I don't believe the build has ever passed on BL8. BUT... there are people who are using blacklight_range_limit on BL8 already anyway...

I will file another PR to no longer test on BL8, so the build can be green again?

@jrochkind
Copy link
Member

dup, handled in #242 instead

@jrochkind jrochkind closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facet field partial does not use modern slot syntax
2 participants