Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExhibitExportSerializer: remove confirmation token #2184

Closed
wants to merge 2 commits into from

Conversation

dunn
Copy link
Contributor

@dunn dunn commented Aug 1, 2019

This avoids the edge case where exporting an exhibit with a contact email then
importing it into the same Spotlight instance causes this sort of error:

F, [2019-07-29T12:32:28.849634 #15168] FATAL -- : [157062cd-0728-432e-8acb-252372f37ce0] ActiveRecord::RecordNotUnique (PG::UniqueViolation: ERROR:  duplicate key value violates unique constraint "index_spotlight_contact_emails_on_confirmation_token"
DETAIL:  Key (confirmation_token)=(R6A-skseGTy41-9EHs5T) already exists.
: INSERT INTO "spotlight_contact_emails" ("exhibit_id", "email", "confirmation_token", "confirmed_at", "confirmation_sent_at", "created_at", "updated_at") VALUES ($1, $2, $3, $4, $5, $6, $7) RETURNING "id"):

This avoids the edge case where exporting an exhibit with a contact email then
importing it into the same Spotlight instance causes this sort of error:
```
F, [2019-07-29T12:32:28.849634 #15168] FATAL -- : [157062cd-0728-432e-8acb-252372f37ce0] ActiveRecord::RecordNotUnique (PG::UniqueViolation: ERROR:  duplicate key value violates unique constraint "index_spotlight_contact_emails_on_confirmation_token"
DETAIL:  Key (confirmation_token)=(R6A-skseGTy41-9EHs5T) already exists.
: INSERT INTO "spotlight_contact_emails" ("exhibit_id", "email", "confirmation_token", "confirmed_at", "confirmation_sent_at", "created_at", "updated_at") VALUES ($1, $2, $3, $4, $5, $6, $7) RETURNING "id"):
```
@dunn dunn added the bug label Aug 1, 2019
@dunn
Copy link
Contributor Author

dunn commented Aug 2, 2019

Looks like the same Travis error as in #2183

@cbeer
Copy link
Member

cbeer commented Aug 7, 2019

Rebased and fixed in #2189.

@cbeer cbeer closed this Aug 7, 2019
@dunn dunn deleted the serializer branch August 7, 2019 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants