Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Migrate to Kubebuilder v3 #392

Open
danehans opened this issue Jun 23, 2021 · 2 comments
Open

Migrate to Kubebuilder v3 #392

danehans opened this issue Jun 23, 2021 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@danehans
Copy link
Contributor

Please describe the problem you have
The operator was bootstrapped using kubebuilder v2 and should consider migrating to v3. Reference the migration guide for additional details.

cc: @BostjanBozic

@danehans danehans added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 23, 2021
@BostjanBozic
Copy link
Contributor

I have been fiddling around a bit, checking how to approach this. My question is, should we try and follow new scaffolded structure/parameters as much as possible or do we just adjust PROJECT file? Some examples:

  • scaffolded manager deployment manifest has health-probe-bind-address flag, should we add it to contour-operator.go?
  • Makefile as quite some changes, e.g. testing is now performed on a fly using temp downloaded binaries for etcd
  • container name of operator is manager, in our case it is contour-operator

I checked codebase and apart from PROJECT file and some of the naming/structural changes, everything is already upgraded (e.g. Reconcile function is already inline with v3, CRDs are already on apiextensions.k8s.io/v1).

@youngnick
Copy link
Member

It seems like if we want to be able to use kubebuilder's CLI tooling, we will need to follow the scaffolded structure as much as possible. That seems like a slightly better plan to me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants