Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --statsd-enabled and related code #1086

Closed
rata opened this issue May 13, 2019 · 1 comment · Fixed by #1094
Closed

Remove --statsd-enabled and related code #1086

rata opened this issue May 13, 2019 · 1 comment · Fixed by #1094
Assignees
@stevesloka
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
0.13.0

Comments

@rata
Copy link
Contributor

rata commented May 13, 2019 •
edited

Describe the solution you'd like
There should be no code for now unsued flags, like --statsd-enabled and friends that is not needed since #1085 (if/when it is merged).

I don't see a reason to not remove it, but would like some opinions first just in case (following the talk then code project recommendation :))

Anything else you would like to add: No

Environment:

  • Contour version: master (before 0.13 release)
@davecheney davecheney added this to the 0.13.0 milestone May 13, 2019
@davecheney davecheney added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels May 13, 2019
@davecheney davecheney mentioned this issue May 14, 2019
Merged
@davecheney davecheney added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label May 14, 2019
@stevesloka
Copy link
Member

In addition to the flag, we can remove the statsd sink from the bootstrap config: https://github.com/heptio/contour/blob/master/internal/envoy/bootstrap.go#L92-L109

@stevesloka stevesloka self-assigned this May 15, 2019
@stevesloka stevesloka removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label May 15, 2019
@stevesloka stevesloka mentioned this issue May 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevesloka stevesloka

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

Remove statsd from boostrap & examples stevesloka/contour
3 participants
@davecheney @rata @stevesloka