Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can I change port for shutdown manager(8090) #5356

Closed
Sinamcp opened this issue May 12, 2023 · 4 comments
Closed

How can I change port for shutdown manager(8090) #5356

Sinamcp opened this issue May 12, 2023 · 4 comments
Labels
kind/question Categorizes an issue as a user question. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor.

Comments

@Sinamcp
Copy link

Sinamcp commented May 12, 2023

What question do you have?:
I deployed 3 envoy on the same edge node, with different ingressclass and hostnetwork: true. I just wanted to know how can I change the shutdown port for each envoy, I mean what the port name is?
For example for liveness porbe is metrics.

Environment:

  • Contour version: 1.25
  • Kubernetes version: 1.23
@Sinamcp Sinamcp added kind/question Categorizes an issue as a user question. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels May 12, 2023
@Sinamcp Sinamcp changed the title How can I change port for shutdown manager How can I change port for shutdown manager(8090) May 12, 2023
@skriss
Copy link
Member

skriss commented May 12, 2023

See https://projectcontour.io/docs/1.25/redeploy-envoy/#shutdown-manager-config-options. You can provide the --serve-port flag to the contour envoy shutdown-manager command (https://github.com/projectcontour/contour/blob/main/examples/contour/03-envoy.yaml#L27-L31), and then change the corresponding port in the preStop hook (ref. https://github.com/projectcontour/contour/blob/main/examples/contour/03-envoy.yaml#L95).

@Sinamcp
Copy link
Author

Sinamcp commented May 12, 2023

Thanks @skriss

      containers:
        - args:
            - envoy
            - "shutdown-manager --serve-port=8091"
          command:
            - contour
          image: 'ghcr.io/projectcontour/contour:v1.25.0'
          imagePullPolicy: IfNotPresent
          lifecycle:
            preStop:
              exec:
                command:
                  - contour
                  - envoy
                  - shutdown
          name: shutdown-manager
          volumeMounts:
            - mountPath: /admin
              name: envoy-admin

is that ok? but it said  contour: error: expected command but got "shutdown-manager --serve-port=8091", try --help

@skriss
Copy link
Member

skriss commented May 12, 2023

Put --serve-port=8091 on a new line within args

@Sinamcp
Copy link
Author

Sinamcp commented May 12, 2023

Thanks a lot @skriss, It works

@Sinamcp Sinamcp closed this as completed May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Categorizes an issue as a user question. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor.
Projects
None yet
Development

No branches or pull requests

2 participants