Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contour gateway api provisionner revert annotations #6446

Open
laserpedro opened this issue May 15, 2024 · 2 comments
Open

Contour gateway api provisionner revert annotations #6446

laserpedro opened this issue May 15, 2024 · 2 comments
Labels
area/gateway-provisioner Issues or PRs related to the Gateway provisioner kind/bug Categorizes issue or PR as related to a bug. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor.

Comments

@laserpedro
Copy link

What steps did you take and what happened:
[A clear and concise description of what the bug is.]

After the service envoy-xxx-gateway is created I patched it as indicated as the doc so that my cloud provider creates the LB. However, I notice that those annotations are overriden with the default ones after a certain amount of time.

What did you expect to happen:

I expect the annotations to remain in the envoy service (they are crucial as they enable the registration of new eks nodes)

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Contour version: 1.29
  • Kubernetes version: (use kubectl version): 1.29
  • Kubernetes installer & version: aws eks
  • Cloud provider or hardware configuration: bottlerocket
  • OS (e.g. from /etc/os-release): linux amazon
@laserpedro laserpedro added kind/bug Categorizes issue or PR as related to a bug. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels May 15, 2024
@laserpedro
Copy link
Author

NOTE: the contourDeployment enables to auto define annotations and tolerations for envoy fleet so I guess that this is in a way solved. However I would be curious to know whether the behavior was intentional to revert the annotations ?

@skriss skriss added the area/gateway-provisioner Issues or PRs related to the Gateway provisioner label May 21, 2024
@skriss
Copy link
Member

skriss commented May 21, 2024

xref #4473

I would say the behavior for this scenario is underspecified; however, I think it would be reasonable for the provisioner to not remove annotations that were set on the service out-of-band, and to only ensure that the annotations the provisioner owns are present and set correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-provisioner Issues or PRs related to the Gateway provisioner kind/bug Categorizes issue or PR as related to a bug. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor.
Projects
None yet
Development

No branches or pull requests

2 participants