Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't interrupt my browsing after a background update #116

Open
NatoBoram opened this issue May 28, 2019 · 6 comments
Open

Don't interrupt my browsing after a background update #116

NatoBoram opened this issue May 28, 2019 · 6 comments
Assignees

Comments

@NatoBoram
Copy link

NatoBoram commented May 28, 2019

It's pretty inconvenient to do so. Please refrain.

@vaxul
Copy link
Contributor

vaxul commented May 28, 2019

Any suggestion on how to do it in a better way?

@Bareus
Copy link
Contributor

Bareus commented May 28, 2019

Maybe the update page should only be shown after firefox has been (re-)started. That way it doesn't interrupt the user while browsing and still give update/release information.
Though I'm not exactly sure how edge cases like manually triggered updates should be handled.

@mgwio
Copy link

mgwio commented May 28, 2019

Just make a new preference like "Display release notes on update" and add a check in onRuntimeInstallNotification. Whether or not to enable or disable it by default is up for debate. I personally find it useful; others like OP don't. I'd argue for opt-out. An "average" user should be informed of any changes that reflect in the behavior or feel of the addon. This could prevent poor reviews (e.g., "Why did this change? 1 star I hate you now >=(" when there's an option to keep it the same) and other trivial issues.

Could also be opt-in with some kind of flag to override default behavior for significant changes, as most users may not care about translation updates and other minor bugfixes.

@projectdelphai
Copy link
Owner

If people are super bothered, there is an option to disable automatic updates globally or per addon. While I understand the frustration with having a tab pop up, we chose to have PTG display release notes since we're doing a lot of changes and new features that are not always backwards compatible. End users often NEED to see these changes so they know why things are changing (such as the fact that the dark mode option didn't disappear, it's now moved to settings).

While ideally the release/changes page wouldn't show until a restart, I'd rather not have extra code just for this small thing unless multiple people think it's a frustrating feature. Still an on-going discussion, but just wanted to put out that there's reasons for this and it's not going to change immediately without some further discussion

@NatoBoram
Copy link
Author

NatoBoram commented May 30, 2019

End users often NEED to see these changes so they know why things are changing

Am end user, don't need to see changelog. At all. You have to understand that I have a job and having a tab randomly open and steal the focus in the middle of the presentation of a web demo is very inconvenient.

One alternative is notifications.

@projectdelphai
Copy link
Owner

Again, this is still something that I'll still be looking into for better alternatives. But just because you personally don't want to see the changelog, doesn't mean that everyone doesn't want to. Maybe "need" was the wrong word, but I still stand behind the fact that it's pretty important to have it there. It's a personal opinion that knowing the changes that are going on in the addons you use are important so that you know what you have installed.

In addition, in an enterprise setting where you don't want strange popups, there is a setting (Firefox-wide or addon-specific) where you can disable automatic updates so that things like this don't happen. You shouldn't be blaming specifically the changelog feature for unexpected things happening. There's a lot worse things that can happen during an addon update. Technically (and these are are possible if rare possibilities), I could re-arrange your tab groups if i needed to create new groups to bring back lost tabs, delete whole groups or wipe all your tabs say if they are corrupted or if there's a bug. If my account was hacked, someone could upload a malicious new version that opens suspicious or inappropriate links as new tabs. All good reasons to disable automatic updates in a setting where consistency is important. It's the same reason that automatic updates can (and should be) disabled on work or data-critical machines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants