Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom IP shouldn't perform DNS resolution #64

Closed
Mzack9999 opened this issue Nov 1, 2022 · 0 comments · Fixed by #67
Closed

Custom IP shouldn't perform DNS resolution #64

Mzack9999 opened this issue Nov 1, 2022 · 0 comments · Fixed by #67
Assignees
@Mzack9999
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@Mzack9999
Copy link
Member

Description

When custom ip is provided via the ip context argument, no other ips should be attempted. Actually we put the custom ip as first to try in the list, and then append all ipv4 and ipv6.
This behavior might not be the expected one, as for those tools using scan all ips functionalities it can cause multiple connections to the same target.
@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Nov 1, 2022
@Mzack9999 Mzack9999 self-assigned this Nov 2, 2022
@Mzack9999 Mzack9999 mentioned this issue Nov 2, 2022
Merged
@Mzack9999 Mzack9999 added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing fallback mechanism with custom ip projectdiscovery/fastdialer
1 participant
@Mzack9999