Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is recommended to save the full favicon_path #1381

Open
Wnltc opened this issue Sep 27, 2023 · 1 comment
Open

It is recommended to save the full favicon_path #1381

Wnltc opened this issue Sep 27, 2023 · 1 comment
Labels
Type: Enhancement Most issues will probably ask for additions or changes.

Comments

@Wnltc
Copy link

Wnltc commented Sep 27, 2023

Please describe your feature request:

Favicons for some sites may be saved on other hosts. It is recommended to save the full favicon_path for easier identification

Describe the use case of this feature:

https://support.dbappsecurity.com.cn/

@Wnltc Wnltc added the Type: Enhancement Most issues will probably ask for additions or changes. label Sep 27, 2023
@yhy0
Copy link

yhy0 commented Nov 29, 2023

It is recommended to check whether the domain name information is included. If there is a way to request to change the favicon url instead of updating the relative path

for example, the favicon path here in jd.com is incorrect.

https://www.jd.com/

<link rel="icon" href="//www.jd.com/favicon.ico" mce_href="//www.jd.com/favicon.ico" type="image/x-icon"/>

Determine whether href is a relative path. If so, update the relative path. Others suggest creating a new request full path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

No branches or pull requests

2 participants