Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] using mapcidr as a lib in readme points to a wrong function name #5

Closed
dogasantos opened this issue Dec 28, 2020 · 2 comments · Fixed by #7
Closed

[Issue] using mapcidr as a lib in readme points to a wrong function name #5

dogasantos opened this issue Dec 28, 2020 · 2 comments · Fixed by #7
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed.

Comments

@dogasantos
Copy link

Hi guys,
Found that your lib offers a mapcidr.IPAddresses function, but your Readme doc has a mapcidr.Ips reference:

// List all ips in the CIDR
	ips, _ := mapcidr.Ips("192.168.1.0/24")
	for _, ip := range ips {
		fmt.Println(ip)
	}

it should be just replaced by

ips, _ := mapcidr.IPAddresses("192.168.1.0/24")

Ty!

@ehsandeep ehsandeep added the Status: In Progress This issue is being worked on, and has someone assigned. label Dec 29, 2020
@ehsandeep ehsandeep changed the title using mapcidr as a lib in readme points to a wrong function name [Issue] using mapcidr as a lib in readme points to a wrong function name Dec 29, 2020
@ehsandeep
Copy link
Member

Thank you for pointing it out @dogasantos, the readme is aligned with the last stable release we created, we made a couple of changes after that and we planned to update them in the next release.

@Mzack9999 Mzack9999 linked a pull request Dec 29, 2020 that will close this issue
@Mzack9999 Mzack9999 added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: In Progress This issue is being worked on, and has someone assigned. labels Jan 7, 2021
@Mzack9999
Copy link
Member

Done in #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants