Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnResult not be invoked when threshold reached #1044

Closed
faint-star opened this issue Apr 26, 2024 · 0 comments · Fixed by #1045
Closed

OnResult not be invoked when threshold reached #1044

faint-star opened this issue Apr 26, 2024 · 0 comments · Fixed by #1045
Assignees
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@faint-star
Copy link

Naabu version:

v2.3.0

Current Behavior:

OnResult not be invoked when threshold reached

Expected Behavior:

onresult can be invoked when threshold reached or provide options to choose wheather the onresult fun should be invoked when the ports threshold reached

Steps To Reproduce:

  1. add demo result fun in v2/cmd/naabu/main.go
options.Stdin = false
	options.OnResult = func(result *result.HostResult) {
		gologger.Info().Msg("Hello")
	}
  1. run with flag -host 183.2.172.185 -pts 2
    image

  2. Threshold reached but OnResult not be invoked

Anything else:

@faint-star faint-star added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Apr 26, 2024
@dogancanbakir dogancanbakir self-assigned this Apr 26, 2024
@dogancanbakir dogancanbakir linked a pull request Apr 26, 2024 that will close this issue
@Mzack9999 Mzack9999 added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants