Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global singleton pcap handlers #937

Closed
Mzack9999 opened this issue Jan 23, 2024 · 0 comments · Fixed by #946
Closed

Global singleton pcap handlers #937

Mzack9999 opened this issue Jan 23, 2024 · 0 comments · Fixed by #946
Assignees
@Mzack9999
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Milestone
naabu v2.3.0

Comments

@Mzack9999
Copy link
Member

Mzack9999 commented Jan 23, 2024 •
edited
Loading

Please describe your feature request:

Rework internals to avoid pcap handlers allocation on each runner execution. The initialization should happen once per instance and just reuse existing ones until the final stop. Additionally it would be useful to implement a continuous process mode (improvement of current streaming) that process chunks in bulk (currently not possible due to busy pcap handlers)
@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Jan 23, 2024
@Mzack9999 Mzack9999 self-assigned this Jan 26, 2024
@Mzack9999 Mzack9999 mentioned this issue Jan 29, 2024
Merged
@Mzack9999 Mzack9999 linked a pull request Jan 30, 2024 that will close this issue
Making pcap handlers shared globally #946
Merged
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Mar 4, 2024
@ehsandeep ehsandeep added this to the naabu v2.3.0 milestone Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
naabu v2.3.0
Development

Successfully merging a pull request may close this issue.

Making pcap handlers shared globally projectdiscovery/naabu
2 participants
@ehsandeep @Mzack9999