Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Add Delay Option #159

Closed
coffeegist opened this issue Jul 26, 2022 · 2 comments · Fixed by #164 or #167
Closed

Feature Request - Add Delay Option #159

coffeegist opened this issue Jul 26, 2022 · 2 comments · Fixed by #164 or #167
Assignees
Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Milestone

Comments

@coffeegist
Copy link

Please describe your feature request:

Currently, notify only supports the -rl rate limit option which has a max limit of 1 request per second. This is too much for some services such as Microsoft Teams connectors and can cause temporary lockouts. (https://docs.microsoft.com/en-us/microsoftteams/platform/webhooks-and-connectors/how-to/connectors-using?tabs=cURL#rate-limiting-for-connectors)

By adding a -delay flag as well (consisting with other PD tools), we could gain better control over the rate at which notifications are sent and avoid having notifications be temporarily blackholed.

Describe the use case of this feature:

As a user, I need to limit my notifications to not exceed 30 requests per hour. To accomplish this, I could use the flag, -delay 2, to add a 2-second delay between each request.

-delay int             delay between requests in seconds (0 to disable) (default 0)
@coffeegist coffeegist added the Type: Enhancement Most issues will probably ask for additions or changes. label Jul 26, 2022
@ehsandeep ehsandeep added the Priority: Medium This issue may be useful, and needs some attention. label Aug 7, 2022
@parrasajad parrasajad self-assigned this Aug 16, 2022
@parrasajad parrasajad linked a pull request Aug 17, 2022 that will close this issue
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Aug 24, 2022
@ehsandeep
Copy link
Member

@coffeegist this is now supported in the dev version of the project using -d option.

@ehsandeep ehsandeep added this to the v1.0.3 milestone Aug 24, 2022
@ehsandeep ehsandeep linked a pull request Aug 24, 2022 that will close this issue
@ehsandeep
Copy link
Member

New release is pushed now - https://github.com/projectdiscovery/notify/releases/tag/v1.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants