Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for discord threads. #190

Closed
CodyCline opened this issue Nov 18, 2022 · 0 comments · Fixed by #191
Closed

Implement support for discord threads. #190

CodyCline opened this issue Nov 18, 2022 · 0 comments · Fixed by #191
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Milestone

Comments

@CodyCline
Copy link
Contributor

CodyCline commented Nov 18, 2022

Please describe your feature request:

Currently, there's no support for streaming messages to discord threads. The only workaround I've found is using the custom option in provider-config.yaml and appending a thread_id parameter to the webhook url.

To stay consistent, the feature would be implemented similarly to how it was in slack; where it sends a generic http request to the webhook service instead of using the default shoutrrr service when discord_threads is set to true (see slack_api.go). All the user has to do is add to their configuration is discord_threads:true AND discord_thread_id: 00000... I'm open to input on the implementation details if there's a better approach. Let me know if you need more information, this was also briefly discussed on your discord server yesterday.

Describe the use case of this feature:

For people that use discord, it would give more control over where notifications are posted to. Threads are extremely helpful in organizing and de-cluttering message channels.

@CodyCline CodyCline added the Type: Enhancement Most issues will probably ask for additions or changes. label Nov 18, 2022
@ehsandeep ehsandeep linked a pull request Nov 19, 2022 that will close this issue
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Mar 9, 2023
@ehsandeep ehsandeep added this to the notify v1.0.5 milestone Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants