Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading go-rod library + crash fixes #1037

Closed
ehsandeep opened this issue Sep 18, 2021 · 1 comment · Fixed by #1038
Closed

Upgrading go-rod library + crash fixes #1037

ehsandeep opened this issue Sep 18, 2021 · 1 comment · Fixed by #1038
Assignees
@Ice3man543
Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
v2.5.2

Comments

@ehsandeep
Copy link
Member

Describe the bug
Nuclei's headless browsing functionality is provided by rod, which utilizes an out-of-date version of chromium that requires updating; additionally, the latest version of rod with updated chromium is incompatible with the nuclei engine, resulting in crashes.

go build
# github.com/projectdiscovery/nuclei/v2/pkg/protocols/headless/engine
../../pkg/protocols/headless/engine/page_actions.go:468:27: too many arguments in call to page.Search
	have (number, number, string)
	want (string)
../../pkg/protocols/headless/engine/page_actions.go:472:9: invalid argument elms (type *rod.SearchResult) for len
../../pkg/protocols/headless/engine/page_actions.go:473:15: invalid operation: elms[0] (type *rod.SearchResult does not support indexing)

Nuclei version
2.5.1
@ehsandeep ehsandeep added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Sep 18, 2021
@ehsandeep ehsandeep added this to To do in v2.5.2 via automation Sep 18, 2021
@ehsandeep ehsandeep added the Priority: High After critical issues are fixed, these should be dealt with before any further issues. label Sep 18, 2021
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Sep 18, 2021
@ehsandeep ehsandeep moved this from To do to Done in v2.5.2 Sep 18, 2021
@ehsandeep
Copy link
Member Author

Fixed with ea8a709

@ehsandeep ehsandeep linked a pull request Sep 18, 2021 that will close this issue
v2.5.2 Bugfix release #1038
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ice3man543 Ice3man543

Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
No open projects
v2.5.2
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v2.5.2 Bugfix release projectdiscovery/nuclei
2 participants
@ehsandeep @Ice3man543