Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issue] Debug mode does not include POST body in the request #162

Closed
ehsandeep opened this issue Jul 17, 2020 · 3 comments · Fixed by #388
Closed

[issue] Debug mode does not include POST body in the request #162

ehsandeep opened this issue Jul 17, 2020 · 3 comments · Fixed by #388
Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Status: Available No one has claimed responsibility for resolving this issue Type: Enhancement Most issues will probably ask for additions or changes.

Comments

@ehsandeep
Copy link
Member

Template used:-

id: test-template

info:
  name: test-template
  author: pdteam
  severity: info


requests:
  - raw:
      - |
        POST /test HTTP/1.1
        Host: {{Hostname}}
        User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

        body=testing

Output:-

echo https://e2hgie9hs7ekv8mhi5v6o3vaj1psdh.burpcollaborator.net | nuclei -t test.yaml -debug

POST /test HTTP/1.1
Host: e2hgie9hs7ekv8mhi5v6o3vaj1psdh.burpcollaborator.net
Connection: close
Connection: close
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

[INF] Dumped HTTP response for https://e2hgie9hs7ekv8mhi5v6o3vaj1psdh.burpcollaborator.net (test-template)

HTTP/1.1 200 OK
Content-Length: 53
Content-Type: text/html
Server: Burp Collaborator https://burpcollaborator.net/
X-Collaborator-Version: 4

<html><body>u8qjvbie59gj1og5tlpzzgzjjgz</body></html>
[INF] No results found for the template. Happy hacking!
@ehsandeep ehsandeep added Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Status: Available No one has claimed responsibility for resolving this issue labels Jul 17, 2020
@manuelbua
Copy link
Contributor

manuelbua commented Jul 17, 2020 •
edited

While taking a look at this i noticed we are using DumpRequest instead of DumpRequestOut, i didn't know there were two versions, the former for server-side requests debugging, the latter for requests going out.

Trying to use DumpRequestOut i encountered a deadlock due to seemingly racy GoLang code at quit, see golang/go#38352 (comment) and golang/go#37669.

@ehsandeep ehsandeep changed the title Debug mode does not include POST body in the request [issue] Debug mode does not include POST body in the request Jul 31, 2020
@Ice3man543
Copy link
Member

@manuelbua nice catch, i thought it would dump request body as well but seems like this is a bug with go. Anyway, let's track that issue and see how things go.

@ehsandeep ehsandeep added Type: Enhancement Most issues will probably ask for additions or changes. and removed Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Oct 10, 2020
@ehsandeep ehsandeep linked a pull request Oct 30, 2020 that will close this issue
[Bugfix] Request Dump #388
Merged
@ehsandeep
Copy link
Member Author

Fixed in the dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Status: Available No one has claimed responsibility for resolving this issue Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Bugfix] Request Dump projectdiscovery/nuclei
3 participants
@manuelbua @ehsandeep @Ice3man543