Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused code in integration tests #3131

Closed
Mzack9999 opened this issue Jan 3, 2023 · 0 comments · Fixed by #3134
Closed

Unused code in integration tests #3131

Mzack9999 opened this issue Jan 3, 2023 · 0 comments · Fixed by #3134
Assignees
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.
Milestone

Comments

@Mzack9999
Copy link
Member

Nuclei version:

main|dev

Current Behavior:

A lot of integration tests cases declares a lot of routerErr variables that are not used in handlers and should be removed if not necessary. For example:

Expected Behavior:

Removed unused code

@Mzack9999 Mzack9999 added the Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. label Jan 3, 2023
@Mzack9999 Mzack9999 self-assigned this Jan 3, 2023
@Mzack9999 Mzack9999 linked a pull request Jan 3, 2023 that will close this issue
4 tasks
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Jan 4, 2023
@ehsandeep ehsandeep added this to the nuclei v2.8.6 milestone Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants