Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

centralized nuclei config management #3572

Closed
tarunKoyalwar opened this issue Apr 19, 2023 · 0 comments · Fixed by #3567
Closed

centralized nuclei config management #3572

tarunKoyalwar opened this issue Apr 19, 2023 · 0 comments · Fixed by #3567
Assignees
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Milestone

Comments

@tarunKoyalwar
Copy link
Member

Nuclei version:

dev | main

Proposed Changes

  • nuclei has many config files ex: ( .nuclei-ignore, .templates-config.json , config.yaml) these config files are used throughout the codebase with different helper functions and redundant error checks and lot of duplicated code .

  • nuclei config should be centralized in gologger.DefaultLogger format . and all config management / updates should be abstracted through this . this automatically takes care of edgecases like (changing directory , missing files , parent directory does not exist and lot more )

  • template directory is also used in multiple locations and is used by almost every package by passing it through functions , types etc . this makes it extremely complex to handle cases where template directory is changed . template directory should be included in ^ default config this makes it more robust and avoids issue caused due to missing directory path

@tarunKoyalwar tarunKoyalwar added Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. Type: Enhancement Most issues will probably ask for additions or changes. and removed Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Apr 19, 2023
@tarunKoyalwar tarunKoyalwar self-assigned this Apr 19, 2023
@tarunKoyalwar tarunKoyalwar linked a pull request Apr 19, 2023 that will close this issue
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Apr 19, 2023
@ehsandeep ehsandeep added this to the nuclei v2.9.2 milestone Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants