Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate govaluate for internal expression engine #4056

Open
Mzack9999 opened this issue Aug 15, 2023 · 0 comments
Open

Deprecate govaluate for internal expression engine #4056

Mzack9999 opened this issue Aug 15, 2023 · 0 comments
Labels
Type: Enhancement Most issues will probably ask for additions or changes.

Comments

@Mzack9999
Copy link
Member

With the planned introduction of goja the internal govaluate to resolve expressions between markers should be replaced with an embedded scripting engine equivalent one.

  • For matchers it's necessary to wrap the js login within an helper function returning a boolean value
  • Extractors should execute the js logic and infer the output values

A previous working implementation with python at #914 for reference, besides code divergences, it's just necessary to drop the nebula engine and adapt the syntax to js. This requires the implementation of projectdiscovery/dsl#79 to enable dsl global functions within the engine itself

@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

No branches or pull requests

1 participant