Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing TestHTTPVariables test #4587

Closed
ehsandeep opened this issue Jan 6, 2024 · 1 comment · Fixed by #4578
Closed

Failing TestHTTPVariables test #4587

ehsandeep opened this issue Jan 6, 2024 · 1 comment · Fixed by #4578
Assignees
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Milestone

Comments

@ehsandeep
Copy link
Member

Nuclei version:

dev

Current Behavior:

ok  	github.com/projectdiscovery/nuclei/v3/pkg/protocols/ssl	0.703s
--- FAIL: TestHTTPVariables (0.00s)
    variables_test.go:44: 
        	Error Trace:	/home/runner/work/nuclei/nuclei/pkg/protocols/utils/variables_test.go:44
        	Error:      	Not equal: 
        	            	expected: "ftp"
        	            	actual  : "foobar.com"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-ftp
        	            	+foobar.com
        	Test:       	TestHTTPVariables
        	Messages:   	incorrect domain name
--- FAIL: TestGetWebsocketVariables (0.00s)
    variables_test.go:164: 
        	Error Trace:	/home/runner/work/nuclei/nuclei/pkg/protocols/utils/variables_test.go:164
        	            				/home/runner/work/nuclei/nuclei/pkg/protocols/utils/variables_test.go:130
        	Error:      	Not equal: 
        	            	expected: "/"
        	            	actual  : ""
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -14,3 +14,3 @@
        	            	  }),
        	            	- ptr: (unsafe.Pointer) 0xc000c650a0,
        	            	+ ptr: (unsafe.Pointer) 0xc000c65090,
        	            	  flag: (reflect.flag) 0x94
        	Test:       	TestGetWebsocketVariables
        	Messages:   	failed return value is not equal to expected
FAIL
FAIL	github.com/projectdiscovery/nuclei/v3/pkg/protocols/utils	0.042s

Expected Behavior:

passing tests!

Steps To Reproduce:

See https://github.com/projectdiscovery/nuclei/pulls/app%2Fdependabot

@ehsandeep ehsandeep added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 6, 2024
@ehsandeep ehsandeep added this to the nuclei v3.1.4 milestone Jan 6, 2024
@Mzack9999
Copy link
Member

Fixed in #4578 via projectdiscovery/utils#302

@ehsandeep ehsandeep linked a pull request Jan 6, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants