Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude printing binary data when v/verbose flag is used #29

Closed
shomodj opened this issue Feb 25, 2021 · 1 comment · Fixed by #61 or #75
Closed

Exclude printing binary data when v/verbose flag is used #29

shomodj opened this issue Feb 25, 2021 · 1 comment · Fixed by #61 or #75
Assignees
@LuitelSamikshya
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.

Comments

@shomodj
Copy link

shomodj commented Feb 25, 2021

I'm thinking that by default verbose flag should not print binary data, and -vv should, any thoughts?
@ehsandeep ehsandeep added the Type: Enhancement Most issues will probably ask for additions or changes. label Mar 30, 2021
@ehsandeep
Copy link
Member

@shomodj definitely a good idea.

@ehsandeep ehsandeep changed the title verbose flag should not print binary by default [Feature] Exclude printing binary data when v/verbose flag is used Mar 30, 2021
@ehsandeep ehsandeep mentioned this issue Mar 30, 2021
Closed
@Mzack9999 Mzack9999 linked a pull request Oct 12, 2021 that will close this issue
verbose flag modification #61
Merged
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Oct 19, 2021
@forgedhallpass forgedhallpass changed the title [Feature] Exclude printing binary data when v/verbose flag is used Exclude printing binary data when v/verbose flag is used Oct 26, 2021
@ehsandeep ehsandeep linked a pull request Nov 19, 2021 that will close this issue
v0.0.5 Release preparation #75
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LuitelSamikshya LuitelSamikshya

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
3 participants
@shomodj @ehsandeep @LuitelSamikshya