Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tests for hosts file Parse function #69

Closed
3 tasks done
Mzack9999 opened this issue Aug 4, 2022 · 0 comments · Fixed by #79
Closed
3 tasks done

Add Tests for hosts file Parse function #69

Mzack9999 opened this issue Aug 4, 2022 · 0 comments · Fixed by #79
Assignees
@xm1k3
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.

Comments

@Mzack9999
Copy link
Member

Mzack9999 commented Aug 4, 2022 •
edited by xm1k3

Please describe your feature request:

Write tests for Parse function at:

retryabledns/hostsfile/hostsfile.go

Line 30 in 45451ae

func Parse(p string) (map[string][]string, error) {

The hosts should cover various possible formats (eg. comments, special characters, ...)

  • Osx
  • Linux
  • Windows
@Mzack9999 Mzack9999 added the Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. label Aug 4, 2022
@xm1k3 xm1k3 linked a pull request Nov 15, 2022 that will close this issue
tests on Parse() function #79
Merged
@Mzack9999 Mzack9999 added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xm1k3 xm1k3

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests on Parse() function projectdiscovery/retryabledns
2 participants
@Mzack9999 @xm1k3