Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails #47

Closed
firefart opened this issue Jan 22, 2023 · 2 comments
Closed

Build fails #47

firefart opened this issue Jan 22, 2023 · 2 comments
Assignees
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@firefart
Copy link

looks like there is an issue with the latest versions of this library and the utils project again. The project does not compile at all.

Error: ../../../go/pkg/mod/github.com/projectdiscovery/retryablehttp-go@v1.0.[9](https://github.com/firefart/hijagger/actions/runs/3979648100/jobs/6822222566#step:6:10)/request.go:102:8: r.URL.Update undefined (type *urlutil.URL has no field or method Update)
Error: ../../../go/pkg/mod/github.com/projectdiscovery/retryablehttp-go@v1.0.9/request.go:[10](https://github.com/firefart/hijagger/actions/runs/3979648100/jobs/6822222566#step:6:11)8:14: r.URL.Clone undefined (type *urlutil.URL has no field or method Clone)
Error: ../../../go/pkg/mod/github.com/projectdiscovery/retryablehttp-go@v1.0.9/request.go:220:21: urlx.URL undefined (type *urlutil.URL has no field or method URL)
Error: ../../../go/pkg/mod/github.com/projectdiscovery/retryablehttp-go@v1.0.9/request.go:247:21: urlx.URL undefined (type *urlutil.URL has no field or method URL)
@firefart firefart added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 22, 2023
@Mzack9999
Copy link
Member

@firefart Thanks for opening this issue. The internal net.URL was replaced with urlutil.URL. We will try tagging a new semantic major version or adding backward compatibility via URL unwrap.

@Mzack9999 Mzack9999 self-assigned this Jan 25, 2023
@Mzack9999
Copy link
Member

@firefart, hopefully, the compilation error can be fixed by changing urlx.URL to urlx.URL.URL. The original URL is within an exported field. We needed to wrap it to extend the standard library functionalities

@Mzack9999 Mzack9999 added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

No branches or pull requests

3 participants