Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests should ignore map iteration order #12

Closed
Mzack9999 opened this issue Nov 3, 2022 · 0 comments · Fixed by #14
Closed

Tests should ignore map iteration order #12

Mzack9999 opened this issue Nov 3, 2022 · 0 comments · Fixed by #14
Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.

Comments

@Mzack9999
Copy link
Member

Mzack9999 commented Nov 3, 2022 •
edited

Description

A few tests fails randomly because the map values are compared with random order. These tests should be modified to make comparison order agnostic (or eg. using require.ElementsMatch).

Ref: https://github.com/projectdiscovery/utils/actions/runs/3383736473/jobs/5619918170#step:4:96
@Mzack9999 Mzack9999 added the Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. label Nov 3, 2022
@ehsandeep ehsandeep added the Priority: High After critical issues are fixed, these should be dealt with before any further issues. label Nov 3, 2022
This was referenced Nov 6, 2022
Closed
Merged
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Nov 6, 2022
@Mzack9999 Mzack9999 mentioned this issue Nov 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update mapsutil #13
2 participants
@ehsandeep @Mzack9999