Replace HashMap with Vec in negotiate_languages #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a slight change in behavior: if two entries have the same language ID, now both entries will be returned instead of the first one. I think the new behavior is preferable though.
|
I just landed a switch very similar to your PR! The only difference is that I use Let me know if you think it's better to clone! |
|
Thanks! I'll close this then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to @cmyr, this reduces the size of druid from 850.5KiB to 841.7KiB.
This is a slight change in behavior: if two entries have the same language ID, now both entries will be returned instead of the first one. I think the new behavior is preferable though.
I'll leave it up to you to decide whether this is a breaking change 馃檪
Partially addresses projectfluent/fluent-rs#139