Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to parse multiline messages with a selector in CRLF formatted fluent file on Windows #191

Closed
kellpossible opened this issue Aug 29, 2020 · 7 comments
Milestone

Comments

@kellpossible
Copy link

kellpossible commented Aug 29, 2020

I'm currently working on producing a minimal example that reproduces this issue, hopefully ready by today. It's a very strange issue! Just saving to LF fixes the problem. It's certainly possible that it's something wrong I'm doing on my end, perhaps while reading the file, if so, I'll close the issue.

@kellpossible
Copy link
Author

kellpossible commented Aug 29, 2020

Here is the reproduction: https://github.com/kellpossible/fluent-multiline-bug
As it happens the same issue occurs on Linux when saving the file as CRLF, so I think it's generally just an issue with it being CRLF.

@zbraniecki
Copy link
Collaborator

Hi! I tried to reproduce it against current master branch and couldn't! Can you verify that this is fixed?

@zbraniecki zbraniecki added this to the 0.13 milestone Sep 18, 2020
@kellpossible
Copy link
Author

@zbraniecki awesome thanks a lot! The problem appears to be fixed on master 🙂 https://github.com/kellpossible/fluent-multiline-bug/tree/fixed-on-master Some small breaking changes with the ast, but I guess that's to be expected when playing with internals. Looking forward to the next release.

@zbraniecki
Copy link
Collaborator

great!

@zbraniecki
Copy link
Collaborator

I'll close it as resolved in 0.13

@kellpossible
Copy link
Author

Just a heads up someone reported a very similar issue kellpossible/cargo-i18n#57 I'll try to make a minimal reproduction again.

@kellpossible
Copy link
Author

I've reported this as a new issue #213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants