Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MessageContext.get_message #60

Closed
stasm opened this issue Aug 7, 2018 · 1 comment
Closed

Remove MessageContext.get_message #60

stasm opened this issue Aug 7, 2018 · 1 comment

Comments

@stasm
Copy link
Contributor

stasm commented Aug 7, 2018

This is similar to projectfluent/fluent.js#208.

I'd like to change MessageContext.format() to accept an identifier of a message and format it directly to a string. It would avoid the intermediate step of having to first get_message the message from the context, which is a bit clunky and is an artifact of how the JavaScript bindings retrieve translated attributes.

@stasm
Copy link
Contributor Author

stasm commented Aug 7, 2018

This is a significant change in the API. I suggest we do it sooner rather than later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant