Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should markup be allowed in attributes set by Localized? #340

Open
stasm opened this issue Feb 15, 2019 · 1 comment
Open

Should markup be allowed in attributes set by Localized? #340

stasm opened this issue Feb 15, 2019 · 1 comment

Comments

@stasm
Copy link
Contributor

stasm commented Feb 15, 2019

<Localized> might wrap an element which accepts localizable props and then inserts them into the DOM as children. In such cases, it might be desirable to run the markup overlay logic on these props too, in addition to the value of the message used by the <Localized> instance.

@soerenBoisen
Copy link

This should absolutely be allowed. Treating children attribute special here violates the principle of least surprise and limits the way we can translate our components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants