Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reevaluate addition of '.idea' to '.gitignore' #163

Closed
elbenfreund opened this issue Nov 16, 2016 · 4 comments
Closed

Reevaluate addition of '.idea' to '.gitignore' #163

elbenfreund opened this issue Nov 16, 2016 · 4 comments
Labels
has PR This issue already has a PR waiting.
Milestone

Comments

@elbenfreund
Copy link
Contributor

PR #160 added .idea to .gitignore.
Right now it is not really clear why this is needed.

@elbenfreund elbenfreund added this to the 0.10.0 milestone Nov 16, 2016
@ghost
Copy link

ghost commented Nov 16, 2016

.idea is a folder created by JetBrain products (I use phpStorm) containing project's configurations.

althrough I understand it's not hamster-shell-extension related. It's a convenience and a security for me to have it on .gitignore .

@elbenfreund
Copy link
Contributor Author

I see. Wouldn't it be better to have this line as part of your "user .gitignore" e.g. ~/.gitignore?

@ghost
Copy link

ghost commented Nov 17, 2016

oh, oh yeah.
I didin't know about --global core.excludesfile
thx

@elbenfreund
Copy link
Contributor Author

anytime :) feel free to create a PR removing .idea from the project specific .gitignore :)

@ghost ghost closed this as completed Jan 27, 2017
@ghost ghost added the has PR This issue already has a PR waiting. label Mar 8, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has PR This issue already has a PR waiting.
Projects
None yet
Development

No branches or pull requests

1 participant