this.panelWidget is null when disabling extension #359
Comments
|
I have also observed this symptom when working on #358, but I think that was then because hamster DBUS disappearing would try to disable the extension twice, leading to this error. In the current develop branch, this disable-on-DBUS-disappear is no longer done, so that cannot explain this problem. But based on my earlier analysis of this error message, I suspect that the Maybe you could add some debug output to check what is happening exactly? You can use the |
|
I have GNOME 44.1 here, same version of the hamster extension, and I don't this issue. Could you add some global.log messages in the disable() method in extension.js and see where the value of this.panelwidget changes to null? |
|
Thanks guys. Not much to add here I'm afraid. Edit I think I got the wrong line 283 before, the line numbers shifted when I added the log lines. I've added
I'm very unfamiliar with Gnome extension code, and the error is not reproducible at present, but I've disabled a lot of other extensions to try to fix a shell crash when pressing Super key for the Overview screen. With others disabled, I will keep an eye on this tomorrow and try to report more info. |
|
I've not had that same error again, but I did just get a slightly different one, around the time that Gnome Shell crashed. I think it's related to the discussion at https://gitlab.gnome.org/GNOME/mutter/-/issues/2700 and is probably not a Hamster problem at all, or may be something that hasn't been guarded against because it's so unexpected. This time, the shell crashed when I hit the Super key to go to the Overview (as in the gitlabl issue above), the shell restarted, then I got a popup message with the same error message as I saw in the journal when checking This was in the middle of lots of error logging relating to the shell crash: So it looks similar to the original |
|
In the middle of the Shell crashing, I suppose anything can happen to a plugin like ours. I wouldn't invest into analyzng this further unless it occurs in a clean environment, too. |
|
@mwilck yeah, I'm with you... I can't reproduce the shell crash reliably enough to debug anything and don't know the code well enough to easily dig deeper. @matthijskooijman can you Close this issue please? I don't have privs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm on Gnome 44 on Fedora 38 running
developbranch latest version (commit 75541ac) and got this error injournalctl -xewhen trying to disable the extension by toggling the slider in Extensions app:The 'places menu' bit might be irrelevant, but that
this.panelWidget is nulllooks like a Hamster Indicator issue. Should I leave this report here, or raise a new Issue?Originally posted by @neekfenwick in #327 (comment)
The text was updated successfully, but these errors were encountered: