Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubopopo #140

Merged
merged 4 commits into from
Sep 28, 2016
Merged

Rubopopo #140

merged 4 commits into from
Sep 28, 2016

Conversation

atz
Copy link
Contributor

@atz atz commented Sep 28, 2016

No description provided.

Starting with:
```
rubocop --auto-correct
--only=Style/AndOr,Style/EmptyLines,Style/EmptyLinesAroundAccessModifier,Style/EmptyLinesAroundBlockBody,Style/EmptyLinesAroundClassBody,Style/ExtraSpacing,Style/ExtraSpacing,Style/CommentIndentation,Style/CommentAnnotation,Style/FirstParameterIndentation,Style/LeadingCommentSpace,Style/MethodDefParentheses,Style/Not,Style/ParenthesesAroundCondition,Style/RedundantReturn,Style/RedundantSelf,Style/SpaceAfterColon,Style/SpaceAfterComma,Style/SpaceAroundEqualsInParameterDefault,Style/SpaceAroundOperators,Style/SpaceBeforeBlockBraces,Style/SpaceBeforeComment,Style/SpaceInsideBlockBraces,Style/SpaceInsideBrackets,Style/SpaceInsideHashLiteralBraces,Style/SpaceInsideParens,Style/SpaceInsidePercentLiteralDelimiters,Style/Tab,Style/TrailingBlankLines,Style/TrailingCommaInLiteral,Style/TrailingWhitespace,Style/UnneededPercentQ,Style/UnneededInterpolation,Rails/ActionFilter,Style/BracesAroundHashParameters
```

And including other hand-applied changes.  See `.rubocop_todo.yml` for
changes.
This is the one with the sizable hash syntax and single-quote changes.

Good enough.
Triple quote operator is not a thing, as it turns out.
@mjgiarlo mjgiarlo merged commit 21d63f3 into master Sep 28, 2016
@mjgiarlo mjgiarlo deleted the rubopopo branch September 28, 2016 23:32
Copy link
Member

@mjgiarlo mjgiarlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@atz atz assigned mbklein and unassigned mbklein Sep 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants